Browse Source

staging: comedi: dt9812: default the analog input gain to 1

The 'default' case should never happen. In case it does, default the
gain to '1'.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten 12 years ago
parent
commit
d6caedf074
1 changed files with 2 additions and 3 deletions
  1. 2 3
      drivers/staging/comedi/drivers/dt9812.c

+ 2 - 3
drivers/staging/comedi/drivers/dt9812.c

@@ -422,6 +422,8 @@ static void dt9812_configure_gain(struct comedi_device *dev,
 		rmw->or_value = F020_MASK_ADC0CF_AMP0GN2 |
 				F020_MASK_ADC0CF_AMP0GN1;
 		break;
+	default:
+		/* this should never happen, just use a gain of 1 */
 	case DT9812_GAIN_1:
 		rmw->or_value = 0x00;
 		break;
@@ -438,9 +440,6 @@ static void dt9812_configure_gain(struct comedi_device *dev,
 	case DT9812_GAIN_16:
 		rmw->or_value = F020_MASK_ADC0CF_AMP0GN2;
 		break;
-	default:
-		dev_err(dev->class_dev, "Illegal gain %d\n", gain);
-		break;
 	}
 }