浏览代码

[NET]: Fix logical error in skb_gso_ok

The test in skb_gso_ok is backwards.  Noticed by Michael Chan
<mchan@broadcom.com>.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Herbert Xu 19 年之前
父节点
当前提交
d6b4991ad5
共有 1 个文件被更改,包括 2 次插入2 次删除
  1. 2 2
      include/linux/netdevice.h

+ 2 - 2
include/linux/netdevice.h

@@ -994,12 +994,12 @@ static inline int skb_gso_ok(struct sk_buff *skb, int features)
 {
 {
 	int feature = skb_shinfo(skb)->gso_size ?
 	int feature = skb_shinfo(skb)->gso_size ?
 		      skb_shinfo(skb)->gso_type << NETIF_F_GSO_SHIFT : 0;
 		      skb_shinfo(skb)->gso_type << NETIF_F_GSO_SHIFT : 0;
-	return (features & feature) != feature;
+	return (features & feature) == feature;
 }
 }
 
 
 static inline int netif_needs_gso(struct net_device *dev, struct sk_buff *skb)
 static inline int netif_needs_gso(struct net_device *dev, struct sk_buff *skb)
 {
 {
-	return skb_gso_ok(skb, dev->features);
+	return !skb_gso_ok(skb, dev->features);
 }
 }
 
 
 #endif /* __KERNEL__ */
 #endif /* __KERNEL__ */