VSOCK: Fix missing msg_namelen update in vsock_stream_recvmsg() · d5e0d0f607 - Gogs

VSOCK: Fix missing msg_namelen update in vsock_stream_recvmsg()

The code misses to update the msg_namelen member to 0 and therefore
makes net/socket.c leak the local, uninitialized sockaddr_storage
variable to userland -- 128 bytes of kernel stack memory.

Cc: Andy King <acking@vmware.com>
Cc: Dmitry Torokhov <dtor@vmware.com>
Cc: George Zhang <georgezhang@vmware.com>
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

Mathias Krause 12 years ago

parent

680d04e0ba

commit

d5e0d0f607

1 changed files with 2 additions and 0 deletions

Split View Show Diff Stats

						
							+ 2
							
							- 0
						
net/vmw_vsock/af_vsock.c
							 
								View File
							
				@@ -1670,6 +1670,8 @@ vsock_stream_recvmsg(struct kiocb *kiocb,
			
				 	vsk = vsock_sk(sk);
			
				 	err = 0;
			
				+	msg->msg_namelen = 0;
			
				+
			
				 	lock_sock(sk);
			
				 	if (sk->sk_state != SS_CONNECTED) {