Selaa lähdekoodia

[XFS] Use the incore inode size in xfs_file_readdir()

We should be using the incore inode size here not the linux inode
size.  The incore inode size is always up to date for directories
whereas the linux inode size is not updated for directories.

We've hit assertions in xfs_bmap() and traced it back to the linux
inode size being zero but the incore size being correct.

Reviewed-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
Lachlan McIlroy 16 vuotta sitten
vanhempi
commit
d415867e0a
1 muutettua tiedostoa jossa 1 lisäystä ja 1 poistoa
  1. 1 1
      fs/xfs/linux-2.6/xfs_file.c

+ 1 - 1
fs/xfs/linux-2.6/xfs_file.c

@@ -204,7 +204,7 @@ xfs_file_readdir(
 	 * point we can change the ->readdir prototype to include the
 	 * point we can change the ->readdir prototype to include the
 	 * buffer size.
 	 * buffer size.
 	 */
 	 */
-	bufsize = (size_t)min_t(loff_t, PAGE_SIZE, inode->i_size);
+	bufsize = (size_t)min_t(loff_t, PAGE_SIZE, ip->i_d.di_size);
 
 
 	error = xfs_readdir(ip, dirent, bufsize,
 	error = xfs_readdir(ip, dirent, bufsize,
 				(xfs_off_t *)&filp->f_pos, filldir);
 				(xfs_off_t *)&filp->f_pos, filldir);