Browse Source

libertas: add comment re: v10 firmware key handling

Comment text suggested by Dan Williams <dcbw@redhat.com> in
<1263952092.4481.2.camel@localhost.localdomain>.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
John W. Linville 15 years ago
parent
commit
d3d5621abf
1 changed files with 5 additions and 0 deletions
  1. 5 0
      drivers/net/wireless/libertas/assoc.c

+ 5 - 0
drivers/net/wireless/libertas/assoc.c

@@ -2062,6 +2062,11 @@ void lbs_association_worker(struct work_struct *work)
 			goto out;
 	}
 
+	/*
+	 * v10 FW wants WPA keys to be set/cleared before WEP key operations,
+	 * otherwise it will fail to correctly associate to WEP networks.
+	 * Other firmware versions don't appear to care.
+	 */
 	if (test_bit(ASSOC_FLAG_WPA_MCAST_KEY, &assoc_req->flags) ||
 	    test_bit(ASSOC_FLAG_WPA_UCAST_KEY, &assoc_req->flags)) {
 		ret = assoc_helper_wpa_keys(priv, assoc_req);