Browse Source

smsc95xx: signedness bug in get_regs()

"retval" has to be a signed integer for the error handling to work.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Dan Carpenter 13 years ago
parent
commit
d348446b88
1 changed files with 2 additions and 1 deletions
  1. 2 1
      drivers/net/usb/smsc95xx.c

+ 2 - 1
drivers/net/usb/smsc95xx.c

@@ -589,7 +589,8 @@ smsc95xx_ethtool_getregs(struct net_device *netdev, struct ethtool_regs *regs,
 			 void *buf)
 			 void *buf)
 {
 {
 	struct usbnet *dev = netdev_priv(netdev);
 	struct usbnet *dev = netdev_priv(netdev);
-	unsigned int i, j, retval;
+	unsigned int i, j;
+	int retval;
 	u32 *data = buf;
 	u32 *data = buf;
 
 
 	retval = smsc95xx_read_reg(dev, ID_REV, &regs->version);
 	retval = smsc95xx_read_reg(dev, ID_REV, &regs->version);