Kaynağa Gözat

HID: hidraw: Replace Confusing += Operator with =

Setting of the return value of hidraw_read() uses the += operator when
= is more appropriate.  There is no case where ret can be anything
other than zero when the assignment is made, making = equivalent to
+= and much more clear.

Signed-off-by: Alan Ott <alan@signal11.us>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Alan Ott 14 yıl önce
ebeveyn
işleme
cf28a67366
1 değiştirilmiş dosya ile 1 ekleme ve 1 silme
  1. 1 1
      drivers/hid/hidraw.c

+ 1 - 1
drivers/hid/hidraw.c

@@ -91,7 +91,7 @@ static ssize_t hidraw_read(struct file *file, char __user *buffer, size_t count,
 			ret = -EFAULT;
 			ret = -EFAULT;
 			goto out;
 			goto out;
 		}
 		}
-		ret += len;
+		ret = len;
 
 
 		kfree(list->buffer[list->tail].value);
 		kfree(list->buffer[list->tail].value);
 		list->tail = (list->tail + 1) & (HIDRAW_BUFFER_SIZE - 1);
 		list->tail = (list->tail + 1) & (HIDRAW_BUFFER_SIZE - 1);