Bläddra i källkod

Revert "[PATCH] x86_64: Fix the node cpumask of a cpu going down"

This reverts commit 10f4dc8b27ac42f930ac55adb8c521264dc997f8.

Quoth Andi Kleen:
  "Kiran decided that it makes the problem worse than it was before.
   Fixing it fully requires more work which is too much for 2.6.16.  So
   please revert that commit for now."

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Linus Torvalds 19 år sedan
förälder
incheckning
cef5076987
2 ändrade filer med 0 tillägg och 10 borttagningar
  1. 0 3
      arch/x86_64/kernel/smpboot.c
  2. 0 7
      include/asm-x86_64/numa.h

+ 0 - 3
arch/x86_64/kernel/smpboot.c

@@ -59,7 +59,6 @@
 #include <asm/nmi.h>
 #include <asm/nmi.h>
 #include <asm/irq.h>
 #include <asm/irq.h>
 #include <asm/hw_irq.h>
 #include <asm/hw_irq.h>
-#include <asm/numa.h>
 
 
 /* Number of siblings per CPU package */
 /* Number of siblings per CPU package */
 int smp_num_siblings = 1;
 int smp_num_siblings = 1;
@@ -891,7 +890,6 @@ do_rest:
 	if (boot_error) {
 	if (boot_error) {
 		cpu_clear(cpu, cpu_callout_map); /* was set here (do_boot_cpu()) */
 		cpu_clear(cpu, cpu_callout_map); /* was set here (do_boot_cpu()) */
 		clear_bit(cpu, &cpu_initialized); /* was set by cpu_init() */
 		clear_bit(cpu, &cpu_initialized); /* was set by cpu_init() */
-		clear_node_cpumask(cpu); /* was set by numa_add_cpu */
 		cpu_clear(cpu, cpu_present_map);
 		cpu_clear(cpu, cpu_present_map);
 		cpu_clear(cpu, cpu_possible_map);
 		cpu_clear(cpu, cpu_possible_map);
 		x86_cpu_to_apicid[cpu] = BAD_APICID;
 		x86_cpu_to_apicid[cpu] = BAD_APICID;
@@ -1189,7 +1187,6 @@ void remove_cpu_from_maps(void)
 	cpu_clear(cpu, cpu_callout_map);
 	cpu_clear(cpu, cpu_callout_map);
 	cpu_clear(cpu, cpu_callin_map);
 	cpu_clear(cpu, cpu_callin_map);
 	clear_bit(cpu, &cpu_initialized); /* was set by cpu_init() */
 	clear_bit(cpu, &cpu_initialized); /* was set by cpu_init() */
-	clear_node_cpumask(cpu);
 }
 }
 
 
 int __cpu_disable(void)
 int __cpu_disable(void)

+ 0 - 7
include/asm-x86_64/numa.h

@@ -22,15 +22,8 @@ extern void numa_set_node(int cpu, int node);
 extern unsigned char apicid_to_node[256];
 extern unsigned char apicid_to_node[256];
 #ifdef CONFIG_NUMA
 #ifdef CONFIG_NUMA
 extern void __init init_cpu_to_node(void);
 extern void __init init_cpu_to_node(void);
-
-static inline void clear_node_cpumask(int cpu)
-{
-	clear_bit(cpu, &node_to_cpumask[cpu_to_node(cpu)]);
-}
-
 #else
 #else
 #define init_cpu_to_node() do {} while (0)
 #define init_cpu_to_node() do {} while (0)
-#define clear_node_cpumask(cpu) do {} while (0)
 #endif
 #endif
 
 
 #define NUMA_NO_NODE 0xff
 #define NUMA_NO_NODE 0xff