Преглед на файлове

x86: Instruction decoder test should generate build warning

Since some instructions are not decoded correctly by older
versions of objdump, it may cause false positive error in insn
decoder posttest.

This changes build error of insn decoder test to build warning.

Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Cc: systemtap <systemtap@sources.redhat.com>
Cc: DLE <dle-develop@lists.sourceforge.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Randy Dunlap <rdunlap@xenotime.net>
Cc: Jim Keniston <jkenisto@us.ibm.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
LKML-Reference: <20091116230631.5250.41579.stgit@harusame>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Masami Hiramatsu преди 15 години
родител
ревизия
ce64c62074
променени са 1 файла, в които са добавени 11 реда и са изтрити 6 реда
  1. 11 6
      arch/x86/tools/test_get_len.c

+ 11 - 6
arch/x86/tools/test_get_len.c

@@ -114,6 +114,7 @@ int main(int argc, char **argv)
 	unsigned char insn_buf[16];
 	unsigned char insn_buf[16];
 	struct insn insn;
 	struct insn insn;
 	int insns = 0, c;
 	int insns = 0, c;
+	int warnings = 0;
 
 
 	parse_args(argc, argv);
 	parse_args(argc, argv);
 
 
@@ -151,18 +152,22 @@ int main(int argc, char **argv)
 		insn_init(&insn, insn_buf, x86_64);
 		insn_init(&insn, insn_buf, x86_64);
 		insn_get_length(&insn);
 		insn_get_length(&insn);
 		if (insn.length != nb) {
 		if (insn.length != nb) {
-			fprintf(stderr, "Error: %s found a difference at %s\n",
+			warnings++;
+			fprintf(stderr, "Warning: %s found difference at %s\n",
 				prog, sym);
 				prog, sym);
-			fprintf(stderr, "Error: %s", line);
-			fprintf(stderr, "Error: objdump says %d bytes, but "
+			fprintf(stderr, "Warning: %s", line);
+			fprintf(stderr, "Warning: objdump says %d bytes, but "
 				"insn_get_length() says %d\n", nb,
 				"insn_get_length() says %d\n", nb,
 				insn.length);
 				insn.length);
 			if (verbose)
 			if (verbose)
 				dump_insn(stderr, &insn);
 				dump_insn(stderr, &insn);
-			exit(2);
 		}
 		}
 	}
 	}
-	fprintf(stderr, "Succeed: decoded and checked %d instructions\n",
-		insns);
+	if (warnings)
+		fprintf(stderr, "Warning: decoded and checked %d"
+			" instructions with %d warnings\n", insns, warnings);
+	else
+		fprintf(stderr, "Succeed: decoded and checked %d"
+			" instructions\n", insns);
 	return 0;
 	return 0;
 }
 }