Pārlūkot izejas kodu

dnotify: do not bother to lock entry->lock when reading mask

entry->lock is needed to make sure entry->mask does not change while
manipulating it.  In dnotify_should_send_event() we don't care if we get an
old or a new mask value out of this entry so there is no point it taking
the lock.

Signed-off-by: Eric Paris <eparis@redhat.com>
Eric Paris 16 gadi atpakaļ
vecāks
revīzija
ce61856bd2
1 mainītis faili ar 1 papildinājumiem un 2 dzēšanām
  1. 1 2
      fs/notify/dnotify/dnotify.c

+ 1 - 2
fs/notify/dnotify/dnotify.c

@@ -153,9 +153,8 @@ static bool dnotify_should_send_event(struct fsnotify_group *group,
 	if (!entry)
 		return false;
 
-	spin_lock(&entry->lock);
 	send = (mask & entry->mask);
-	spin_unlock(&entry->lock);
+
 	fsnotify_put_mark(entry); /* matches fsnotify_find_mark_entry */
 
 	return send;