浏览代码

drivers/ide/arm/icside.c: kmalloc + memset conversion to kzalloc

Is this a bug? In original verison memset cleared sizeof(state) bytes
instead of sizeof(*state). If it was intentional then this patch is invalid.
If not intentional -> valid :) Please review.

Bart: Yes, it is a bug so this patch is a valid bugfix. :-)

 drivers/ide/arm/icside.c | 18883 -> 18849 (-34 bytes)

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Mariusz Kozlowski 18 年之前
父节点
当前提交
cc60d8baa3
共有 1 个文件被更改,包括 1 次插入2 次删除
  1. 1 2
      drivers/ide/arm/icside.c

+ 1 - 2
drivers/ide/arm/icside.c

@@ -693,13 +693,12 @@ icside_probe(struct expansion_card *ec, const struct ecard_id *id)
 	if (ret)
 	if (ret)
 		goto out;
 		goto out;
 
 
-	state = kmalloc(sizeof(struct icside_state), GFP_KERNEL);
+	state = kzalloc(sizeof(struct icside_state), GFP_KERNEL);
 	if (!state) {
 	if (!state) {
 		ret = -ENOMEM;
 		ret = -ENOMEM;
 		goto release;
 		goto release;
 	}
 	}
 
 
-	memset(state, 0, sizeof(state));
 	state->type	= ICS_TYPE_NOTYPE;
 	state->type	= ICS_TYPE_NOTYPE;
 	state->dev	= &ec->dev;
 	state->dev	= &ec->dev;