瀏覽代碼

net/rxrpc/ar-peer.c: remove invalid reference to list iterator variable

If list_for_each_entry, etc complete a traversal of the list, the iterator
variable ends up pointing to an address at an offset from the list head,
and not a meaningful structure.  Thus this value should not be used after
the end of the iterator.  This seems to be a copy-paste bug from a previous
debugging message, and so the meaningless value is just deleted.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Julia Lawall 13 年之前
父節點
當前提交
cae296c42c
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      net/rxrpc/ar-peer.c

+ 1 - 1
net/rxrpc/ar-peer.c

@@ -229,7 +229,7 @@ found_UDP_peer:
 	return peer;
 	return peer;
 
 
 new_UDP_peer:
 new_UDP_peer:
-	_net("Rx UDP DGRAM from NEW peer %d", peer->debug_id);
+	_net("Rx UDP DGRAM from NEW peer");
 	read_unlock_bh(&rxrpc_peer_lock);
 	read_unlock_bh(&rxrpc_peer_lock);
 	_leave(" = -EBUSY [new]");
 	_leave(" = -EBUSY [new]");
 	return ERR_PTR(-EBUSY);
 	return ERR_PTR(-EBUSY);