Browse Source

CDC NCM: Use kzalloc rather than kmalloc followed by memset with 0

This considers some simple cases that are common and easy to validate
Note in particular that there are no ...s in the rule, so all of the
matched code has to be contiguous

The semantic patch that makes this change is available
in scripts/coccinelle/api/alloc/kzalloc-simple.cocci.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Thomas Meyer 13 years ago
parent
commit
c796984f2f
1 changed files with 1 additions and 3 deletions
  1. 1 3
      drivers/net/usb/cdc_ncm.c

+ 1 - 3
drivers/net/usb/cdc_ncm.c

@@ -465,12 +465,10 @@ static int cdc_ncm_bind(struct usbnet *dev, struct usb_interface *intf)
 	int temp;
 	int temp;
 	u8 iface_no;
 	u8 iface_no;
 
 
-	ctx = kmalloc(sizeof(*ctx), GFP_KERNEL);
+	ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
 	if (ctx == NULL)
 	if (ctx == NULL)
 		return -ENODEV;
 		return -ENODEV;
 
 
-	memset(ctx, 0, sizeof(*ctx));
-
 	init_timer(&ctx->tx_timer);
 	init_timer(&ctx->tx_timer);
 	spin_lock_init(&ctx->mtx);
 	spin_lock_init(&ctx->mtx);
 	ctx->netdev = dev->net;
 	ctx->netdev = dev->net;