Sfoglia il codice sorgente

[SCSI] qla2xxx: Correct truncation in return-code status checking.

QLA_* return codes are 'int' in size.  There were still several
legacy check-points which assumed a return-code width of 8-bits.
This could cause incorrect assumptions of 'good' status if a
return of QLA_FUNCTION_TIMEOUT.

Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Andrew Vasquez 16 anni fa
parent
commit
c6b2fca820
2 ha cambiato i file con 2 aggiunte e 2 eliminazioni
  1. 1 1
      drivers/scsi/qla2xxx/qla_init.c
  2. 1 1
      drivers/scsi/qla2xxx/qla_os.c

+ 1 - 1
drivers/scsi/qla2xxx/qla_init.c

@@ -3435,7 +3435,7 @@ qla2x00_abort_isp(scsi_qla_host_t *vha)
 static int
 qla2x00_restart_isp(scsi_qla_host_t *vha)
 {
-	uint8_t		status = 0;
+	int status = 0;
 	uint32_t wait_time;
 	struct qla_hw_data *ha = vha->hw;
 	struct req_que *req = ha->req_q_map[0];

+ 1 - 1
drivers/scsi/qla2xxx/qla_os.c

@@ -2568,7 +2568,7 @@ qla2x00_do_work(struct scsi_qla_host *vha)
 void qla2x00_relogin(struct scsi_qla_host *vha)
 {
 	fc_port_t       *fcport;
-	uint8_t         status;
+	int status;
 	uint16_t        next_loopid = 0;
 	struct qla_hw_data *ha = vha->hw;