Browse Source

RDMA/amso1100: Fix error paths in post_send and post_recv

Always set bad_wr when an immediate error is detected.

Signed-off-by: Frank Zago <fzago@systemfabricworks.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Frank Zago 15 years ago
parent
commit
c597b0240b
1 changed files with 10 additions and 4 deletions
  1. 10 4
      drivers/infiniband/hw/amso1100/c2_qp.c

+ 10 - 4
drivers/infiniband/hw/amso1100/c2_qp.c

@@ -798,8 +798,10 @@ int c2_post_send(struct ib_qp *ibqp, struct ib_send_wr *ib_wr,
 	u8 actual_sge_count;
 	u8 actual_sge_count;
 	u32 msg_size;
 	u32 msg_size;
 
 
-	if (qp->state > IB_QPS_RTS)
-		return -EINVAL;
+	if (qp->state > IB_QPS_RTS) {
+		err = -EINVAL;
+		goto out;
+	}
 
 
 	while (ib_wr) {
 	while (ib_wr) {
 
 
@@ -930,6 +932,7 @@ int c2_post_send(struct ib_qp *ibqp, struct ib_send_wr *ib_wr,
 		ib_wr = ib_wr->next;
 		ib_wr = ib_wr->next;
 	}
 	}
 
 
+out:
 	if (err)
 	if (err)
 		*bad_wr = ib_wr;
 		*bad_wr = ib_wr;
 	return err;
 	return err;
@@ -944,8 +947,10 @@ int c2_post_receive(struct ib_qp *ibqp, struct ib_recv_wr *ib_wr,
 	unsigned long lock_flags;
 	unsigned long lock_flags;
 	int err = 0;
 	int err = 0;
 
 
-	if (qp->state > IB_QPS_RTS)
-		return -EINVAL;
+	if (qp->state > IB_QPS_RTS) {
+		err = -EINVAL;
+		goto out;
+	}
 
 
 	/*
 	/*
 	 * Try and post each work request
 	 * Try and post each work request
@@ -998,6 +1003,7 @@ int c2_post_receive(struct ib_qp *ibqp, struct ib_recv_wr *ib_wr,
 		ib_wr = ib_wr->next;
 		ib_wr = ib_wr->next;
 	}
 	}
 
 
+out:
 	if (err)
 	if (err)
 		*bad_wr = ib_wr;
 		*bad_wr = ib_wr;
 	return err;
 	return err;