net/bridge: use kobject_put to release kobject in br_add_if error path · c587aea951 - Gogs

net/bridge: use kobject_put to release kobject in br_add_if error path

kobject_init_and_add will alloc memory for kobj->name, so in br_add_if
error path, simply use kobject_del will not free memory for kobj->name.
Fix by using kobject_put instead, kobject_put will internally calls
kobject_del and frees memory for kobj->name.

Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

Xiaotian Feng 16 years ago

parent

4a29f39642

commit

c587aea951

1 changed files with 1 additions and 1 deletions

Split View Show Diff Stats

						
							+ 1
							
							- 1
						
net/bridge/br_if.c
							 
								View File
							
				@@ -424,7 +424,7 @@ int br_add_if(struct net_bridge *br, struct net_device *dev)
			
				 err2:
			
				 	br_fdb_delete_by_port(br, p, 1);
			
				 err1:
			
				-	kobject_del(&p->kobj);
			
				+	kobject_put(&p->kobj);
			
				 err0:
			
				 	dev_set_promiscuity(dev, -1);
			
				 put_back: