فهرست منبع

dmapools: protect page_list walk in show_pools()

show_pools() walks the page_list of a pool w/o protection against the list
modifications in alloc/free.  Take pool->lock to avoid stomping into
nirvana.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Thomas Gleixner 16 سال پیش
والد
کامیت
c49568235d
1فایلهای تغییر یافته به همراه2 افزوده شده و 0 حذف شده
  1. 2 0
      mm/dmapool.c

+ 2 - 0
mm/dmapool.c

@@ -86,10 +86,12 @@ show_pools(struct device *dev, struct device_attribute *attr, char *buf)
 		unsigned pages = 0;
 		unsigned pages = 0;
 		unsigned blocks = 0;
 		unsigned blocks = 0;
 
 
+		spin_lock_irq(&pool->lock);
 		list_for_each_entry(page, &pool->page_list, page_list) {
 		list_for_each_entry(page, &pool->page_list, page_list) {
 			pages++;
 			pages++;
 			blocks += page->in_use;
 			blocks += page->in_use;
 		}
 		}
+		spin_unlock_irq(&pool->lock);
 
 
 		/* per-pool info, no real statistics yet */
 		/* per-pool info, no real statistics yet */
 		temp = scnprintf(next, size, "%-16s %4u %4Zu %4Zu %2u\n",
 		temp = scnprintf(next, size, "%-16s %4u %4Zu %4Zu %2u\n",