Jelajahi Sumber

ASoC: wm0010: Fix possible out-of-bounds array read

Spotted by coverity CID 744701.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
Takashi Iwai 11 tahun lalu
induk
melakukan
c36c89096c
1 mengubah file dengan 4 tambahan dan 4 penghapusan
  1. 4 4
      sound/soc/codecs/wm0010.c

+ 4 - 4
sound/soc/codecs/wm0010.c

@@ -793,11 +793,11 @@ static int wm0010_set_sysclk(struct snd_soc_codec *codec, int source,
 		wm0010->max_spi_freq = 0;
 		wm0010->max_spi_freq = 0;
 	} else {
 	} else {
 		for (i = 0; i < ARRAY_SIZE(pll_clock_map); i++)
 		for (i = 0; i < ARRAY_SIZE(pll_clock_map); i++)
-			if (freq >= pll_clock_map[i].max_sysclk)
+			if (freq >= pll_clock_map[i].max_sysclk) {
+				wm0010->max_spi_freq = pll_clock_map[i].max_pll_spi_speed;
+				wm0010->pll_clkctrl1 = pll_clock_map[i].pll_clkctrl1;
 				break;
 				break;
-
-		wm0010->max_spi_freq = pll_clock_map[i].max_pll_spi_speed;
-		wm0010->pll_clkctrl1 = pll_clock_map[i].pll_clkctrl1;
+			}
 	}
 	}
 
 
 	return 0;
 	return 0;