Эх сурвалжийг харах

fs: Use BUG_ON(!mnt) at dentry_open().

dentry_open() requires callers to pass a valid vfsmount.

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Tetsuo Handa 14 жил өмнө
parent
commit
c212f9aaf9
1 өөрчлөгдсөн 2 нэмэгдсэн , 11 устгасан
  1. 2 11
      fs/open.c

+ 2 - 11
fs/open.c

@@ -835,17 +835,8 @@ struct file *dentry_open(struct dentry *dentry, struct vfsmount *mnt, int flags,
 
 
 	validate_creds(cred);
 	validate_creds(cred);
 
 
-	/*
-	 * We must always pass in a valid mount pointer.   Historically
-	 * callers got away with not passing it, but we must enforce this at
-	 * the earliest possible point now to avoid strange problems deep in the
-	 * filesystem stack.
-	 */
-	if (!mnt) {
-		printk(KERN_WARNING "%s called with NULL vfsmount\n", __func__);
-		dump_stack();
-		return ERR_PTR(-EINVAL);
-	}
+	/* We must always pass in a valid mount pointer. */
+	BUG_ON(!mnt);
 
 
 	error = -ENFILE;
 	error = -ENFILE;
 	f = get_empty_filp();
 	f = get_empty_filp();