Эх сурвалжийг харах

net/hyperv: fix possible memory leak in do_set_multicast()

do_set_multicast() may not free the memory malloc in
netvsc_set_multicast_list().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Wei Yongjun 13 жил өмнө
parent
commit
c11bf1c8ba

+ 3 - 2
drivers/net/hyperv/netvsc_drv.c

@@ -68,11 +68,11 @@ static void do_set_multicast(struct work_struct *w)
 
 
 	nvdev = hv_get_drvdata(ndevctx->device_ctx);
 	nvdev = hv_get_drvdata(ndevctx->device_ctx);
 	if (nvdev == NULL)
 	if (nvdev == NULL)
-		return;
+		goto out;
 
 
 	rdev = nvdev->extension;
 	rdev = nvdev->extension;
 	if (rdev == NULL)
 	if (rdev == NULL)
-		return;
+		goto out;
 
 
 	if (net->flags & IFF_PROMISC)
 	if (net->flags & IFF_PROMISC)
 		rndis_filter_set_packet_filter(rdev,
 		rndis_filter_set_packet_filter(rdev,
@@ -83,6 +83,7 @@ static void do_set_multicast(struct work_struct *w)
 			NDIS_PACKET_TYPE_ALL_MULTICAST |
 			NDIS_PACKET_TYPE_ALL_MULTICAST |
 			NDIS_PACKET_TYPE_DIRECTED);
 			NDIS_PACKET_TYPE_DIRECTED);
 
 
+out:
 	kfree(w);
 	kfree(w);
 }
 }