Browse Source

raw: BKL pushdown

Put explicit lock_kernel() calls into raw_open(), even though the existing
locking looks adequate.

Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Jonathan Corbet 17 years ago
parent
commit
c0bed680f0
1 changed files with 3 additions and 0 deletions
  1. 3 0
      drivers/char/raw.c

+ 3 - 0
drivers/char/raw.c

@@ -19,6 +19,7 @@
 #include <linux/cdev.h>
 #include <linux/cdev.h>
 #include <linux/device.h>
 #include <linux/device.h>
 #include <linux/mutex.h>
 #include <linux/mutex.h>
+#include <linux/smp_lock.h>
 
 
 #include <asm/uaccess.h>
 #include <asm/uaccess.h>
 
 
@@ -53,6 +54,7 @@ static int raw_open(struct inode *inode, struct file *filp)
 		return 0;
 		return 0;
 	}
 	}
 
 
+	lock_kernel();
 	mutex_lock(&raw_mutex);
 	mutex_lock(&raw_mutex);
 
 
 	/*
 	/*
@@ -79,6 +81,7 @@ static int raw_open(struct inode *inode, struct file *filp)
 			bdev->bd_inode->i_mapping;
 			bdev->bd_inode->i_mapping;
 	filp->private_data = bdev;
 	filp->private_data = bdev;
 	mutex_unlock(&raw_mutex);
 	mutex_unlock(&raw_mutex);
+	unlock_kernel();
 	return 0;
 	return 0;
 
 
 out2:
 out2: