Эх сурвалжийг харах

68360serial: Note that there isn't any info->mcr locking

Noticed while auditing the code for the BKL elimination project

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Alan Cox 17 жил өмнө
parent
commit
c0754c99a6

+ 1 - 1
drivers/serial/68360serial.c

@@ -1282,7 +1282,7 @@ static int rs_360_tiocmset(struct tty_struct *tty, struct file *file,
 
 
 	if (tty->flags & (1 << TTY_IO_ERROR))
 	if (tty->flags & (1 << TTY_IO_ERROR))
 		return -EIO;
 		return -EIO;
-
+	/* FIXME: locking on info->mcr */
  	if (set & TIOCM_RTS)
  	if (set & TIOCM_RTS)
  		info->mcr |= UART_MCR_RTS;
  		info->mcr |= UART_MCR_RTS;
  	if (set & TIOCM_DTR)
  	if (set & TIOCM_DTR)