Explorar o código

sound/oss/trident.c: fix incorrect test in trident_ac97_set()

If count reaches zero, the loop ends, but the postfix decrement still
subtracts: testing for 'count == 0' will not work.

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Reviewed-by: Ray Lee <ray-lk@madrabbit.org>
Acked-by: Muli Ben-Yehuda <muli@il.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Roel Kluin %!s(int64=17) %!d(string=hai) anos
pai
achega
be6c28e62e
Modificáronse 1 ficheiros con 2 adicións e 2 borrados
  1. 2 2
      sound/oss/trident.c

+ 2 - 2
sound/oss/trident.c

@@ -2935,7 +2935,7 @@ trident_ac97_set(struct ac97_codec *codec, u8 reg, u16 val)
 	do {
 	do {
 		if ((inw(TRID_REG(card, address)) & busy) == 0)
 		if ((inw(TRID_REG(card, address)) & busy) == 0)
 			break;
 			break;
-	} while (count--);
+	} while (--count);
 
 
 	data |= (mask | (reg & AC97_REG_ADDR));
 	data |= (mask | (reg & AC97_REG_ADDR));
 
 
@@ -2996,7 +2996,7 @@ trident_ac97_get(struct ac97_codec *codec, u8 reg)
 		data = inl(TRID_REG(card, address));
 		data = inl(TRID_REG(card, address));
 		if ((data & busy) == 0)
 		if ((data & busy) == 0)
 			break;
 			break;
-	} while (count--);
+	} while (--count);
 	spin_unlock_irqrestore(&card->lock, flags);
 	spin_unlock_irqrestore(&card->lock, flags);
 
 
 	if (count == 0) {
 	if (count == 0) {