浏览代码

[ALSA] sound/isa/sb/sb_mixer.c double kfree

Modules: SB drivers

snd_ctl_add() already does the free on error.

Coverity bug #957

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Dave Jones 19 年之前
父节点
当前提交
bcc54f9a56
共有 1 个文件被更改,包括 1 次插入3 次删除
  1. 1 3
      sound/isa/sb/sb_mixer.c

+ 1 - 3
sound/isa/sb/sb_mixer.c

@@ -453,10 +453,8 @@ int snd_sbmixer_add_ctl(struct snd_sb *chip, const char *name, int index, int ty
 	strlcpy(ctl->id.name, name, sizeof(ctl->id.name));
 	ctl->id.index = index;
 	ctl->private_value = value;
-	if ((err = snd_ctl_add(chip->card, ctl)) < 0) {
-		snd_ctl_free_one(ctl);
+	if ((err = snd_ctl_add(chip->card, ctl)) < 0)
 		return err;
-	}
 	return 0;
 }