Browse Source

[SCSI] qla2xxx: fix lock imbalance

Stanse found that one error path in qla24xx_bsg_timeout omits to
unlock ha->hardware_lock. Fix that.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Acked-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Jiri Slaby 15 years ago
parent
commit
bc0beb44f2
1 changed files with 1 additions and 0 deletions
  1. 1 0
      drivers/scsi/qla2xxx/qla_attr.c

+ 1 - 0
drivers/scsi/qla2xxx/qla_attr.c

@@ -2393,6 +2393,7 @@ qla24xx_bsg_timeout(struct fc_bsg_job *bsg_job)
 	return 0;
 	return 0;
 
 
 done:
 done:
+	spin_unlock_irqrestore(&ha->hardware_lock, flags);
 	if (bsg_job->request->msgcode == FC_BSG_HST_CT)
 	if (bsg_job->request->msgcode == FC_BSG_HST_CT)
 		kfree(sp->fcport);
 		kfree(sp->fcport);
 	kfree(sp->ctx);
 	kfree(sp->ctx);