Parcourir la source

[media] TTUSB DVB: ttusb_boot_dsp() needs to release_firmware() or it leaks memory

In drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c:ttusb_boot_dsp() we
need to call release_firmware(fw) before returning or we'll leak - no
matter if we succeed or fail.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Jesper Juhl il y a 14 ans
Parent
commit
ba0fd56a4f
1 fichiers modifiés avec 1 ajouts et 0 suppressions
  1. 1 0
      drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c

+ 1 - 0
drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c

@@ -334,6 +334,7 @@ static int ttusb_boot_dsp(struct ttusb *ttusb)
 	err = ttusb_cmd(ttusb, b, 4, 0);
 
       done:
+	release_firmware(fw);
 	if (err) {
 		dprintk("%s: usb_bulk_msg() failed, return value %i!\n",
 			__func__, err);