Browse Source

[PATCH] NFS: remove unused check in nfs4_open_revalidate

Coverity spotted a superfluous error check in nfs4_open_revalidate().  Remove
it.

Coverity: #cid 847

Test plan:
Code inspection; another pass through Coverity.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Chuck Lever 18 years ago
parent
commit
b87c0adfea
1 changed files with 2 additions and 4 deletions
  1. 2 4
      fs/nfs/nfs4proc.c

+ 2 - 4
fs/nfs/nfs4proc.c

@@ -1314,11 +1314,9 @@ nfs4_open_revalidate(struct inode *dir, struct dentry *dentry, int openflags, st
 			case -EROFS:
 			case -EROFS:
 				lookup_instantiate_filp(nd, (struct dentry *)state, NULL);
 				lookup_instantiate_filp(nd, (struct dentry *)state, NULL);
 				return 1;
 				return 1;
-			case -ENOENT:
-				if (dentry->d_inode == NULL)
-					return 1;
+			default:
+				goto out_drop;
 		}
 		}
-		goto out_drop;
 	}
 	}
 	if (state->inode == dentry->d_inode) {
 	if (state->inode == dentry->d_inode) {
 		nfs4_intent_set_file(nd, dentry, state);
 		nfs4_intent_set_file(nd, dentry, state);