Ver código fonte

sound: seq_midi: do not send MIDI reset when closing

Sending a MIDI reset message when closing a port is wrong because we
only want to shut the device up, not to reset all settings.
Furthermore, many devices ignore this message.

Fortunately, the RawMIDI layer already shuts the device up, so we can
ignore this matter here.

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Clemens Ladisch 16 anos atrás
pai
commit
b86c87288c
1 arquivos alterados com 0 adições e 3 exclusões
  1. 0 3
      sound/core/seq/seq_midi.c

+ 0 - 3
sound/core/seq/seq_midi.c

@@ -249,12 +249,9 @@ static int midisynth_use(void *private_data, struct snd_seq_port_subscribe *info
 static int midisynth_unuse(void *private_data, struct snd_seq_port_subscribe *info)
 static int midisynth_unuse(void *private_data, struct snd_seq_port_subscribe *info)
 {
 {
 	struct seq_midisynth *msynth = private_data;
 	struct seq_midisynth *msynth = private_data;
-	unsigned char buf = 0xff; /* MIDI reset */
 
 
 	if (snd_BUG_ON(!msynth->output_rfile.output))
 	if (snd_BUG_ON(!msynth->output_rfile.output))
 		return -EINVAL;
 		return -EINVAL;
-	/* sending single MIDI reset message to shut the device up */
-	snd_rawmidi_kernel_write(msynth->output_rfile.output, &buf, 1);
 	snd_rawmidi_drain_output(msynth->output_rfile.output);
 	snd_rawmidi_drain_output(msynth->output_rfile.output);
 	return snd_rawmidi_kernel_release(&msynth->output_rfile);
 	return snd_rawmidi_kernel_release(&msynth->output_rfile);
 }
 }