Browse Source

drm/i915: avoid non-atomic sysrq execution

The sysrq functions are executed in hardirq context, so we shouldn't be
calling sleeping functions from them, like mutex_locks or memory
allocations.

Fix up the i915 sysrq handler to avoid this.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Eric Anholt <eric@anholt.net>
Jesse Barnes 16 years ago
parent
commit
b66d18ddb1
1 changed files with 7 additions and 1 deletions
  1. 7 1
      drivers/gpu/drm/i915/intel_fb.c

+ 7 - 1
drivers/gpu/drm/i915/intel_fb.c

@@ -857,9 +857,15 @@ void intelfb_restore(void)
 	drm_crtc_helper_set_config(&kernelfb_mode);
 	drm_crtc_helper_set_config(&kernelfb_mode);
 }
 }
 
 
+static void intelfb_restore_work_fn(struct work_struct *ignored)
+{
+	intelfb_restore();
+}
+static DECLARE_WORK(intelfb_restore_work, intelfb_restore_work_fn);
+
 static void intelfb_sysrq(int dummy1, struct tty_struct *dummy3)
 static void intelfb_sysrq(int dummy1, struct tty_struct *dummy3)
 {
 {
-        intelfb_restore();
+        schedule_work(&intelfb_restore_work);
 }
 }
 
 
 static struct sysrq_key_op sysrq_intelfb_restore_op = {
 static struct sysrq_key_op sysrq_intelfb_restore_op = {