Selaa lähdekoodia

Blackfin: bf54x: don't ack GPIO ints when unmasking them

When unmasking a GPIO interrupt on a BF54x part, the code will implicitly
ack any pending interrupts.  This is not what unmasking should do and can
cause people to miss interrupts from their devices, so punt the code.

Reported-by: Rutger Hofman <rutger@cs.vu.nl>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Mike Frysinger 14 vuotta sitten
vanhempi
commit
b66acb63f5
1 muutettua tiedostoa jossa 0 lisäystä ja 1 poistoa
  1. 0 1
      arch/blackfin/mach-common/ints-priority.c

+ 0 - 1
arch/blackfin/mach-common/ints-priority.c

@@ -866,7 +866,6 @@ static void bfin_gpio_unmask_irq(unsigned int irq)
 	u32 pintbit = PINT_BIT(pint_val);
 	u32 bank = PINT_2_BANK(pint_val);
 
-	pint[bank]->request = pintbit;
 	pint[bank]->mask_set = pintbit;
 }