Browse Source

dell-laptop - using buffer without mutex_lock

Using buffer->output[1] without mutex_lock()

Signed-off-by: Jose Alonso <joalonsof@gmail.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Jose Alonso 14 years ago
parent
commit
b486742a12
1 changed files with 3 additions and 3 deletions
  1. 3 3
      drivers/platform/x86/dell-laptop.c

+ 3 - 3
drivers/platform/x86/dell-laptop.c

@@ -540,11 +540,11 @@ static int dell_get_intensity(struct backlight_device *bd)
 	else
 		dell_send_request(buffer, 0, 1);
 
+	ret = buffer->output[1];
+
 out:
 	release_buffer();
-	if (ret)
-		return ret;
-	return buffer->output[1];
+	return ret;
 }
 
 static const struct backlight_ops dell_ops = {