Преглед на файлове

[POWERPC] Remove gratuitous reads from pasemi pci config space methods

The pasemi pci configuration space write method reads the written
location immediately after the write is performed, presumably in order
to flush the write.  However, configuration space writes are not
allowed to be posted, making these reads gratuitous.  Furthermore,
this behavior potentially causes us to violate the PCI PM spec when
changing between e.g. D0 and D3 states, because a delay of up to 10ms
may be required before the OS accesses configuration space after the
write which initiates the transition.

Remove the unnecessary reads from pa_pxp_write_config.

Signed-off-by: Nathan Lynch <ntl@pobox.com>
Acked-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Nathan Lynch преди 18 години
родител
ревизия
b139f1fb0f
променени са 1 файла, в които са добавени 0 реда и са изтрити 3 реда
  1. 0 3
      arch/powerpc/platforms/pasemi/pci.c

+ 0 - 3
arch/powerpc/platforms/pasemi/pci.c

@@ -107,15 +107,12 @@ static int pa_pxp_write_config(struct pci_bus *bus, unsigned int devfn,
 	switch (len) {
 	switch (len) {
 	case 1:
 	case 1:
 		out_8(addr, val);
 		out_8(addr, val);
-		(void) in_8(addr);
 		break;
 		break;
 	case 2:
 	case 2:
 		out_le16(addr, val);
 		out_le16(addr, val);
-		(void) in_le16(addr);
 		break;
 		break;
 	default:
 	default:
 		out_le32(addr, val);
 		out_le32(addr, val);
-		(void) in_le32(addr);
 		break;
 		break;
 	}
 	}
 	return PCIBIOS_SUCCESSFUL;
 	return PCIBIOS_SUCCESSFUL;