浏览代码

RDMA/cxgb3: Fix too-big reserved field zeroing in iwch_post_zb_read()

The array wqe->read.reserved has only two entries, but
iwch_post_zb_read() sets [0], [1], and [2], which is one too many.
This is harmless since it runs into the next field, rem_stag, which is
initialized correctly immediately after, but we might as well get
things right, especially since it makes the code smaller.

This was spotted by the Coverity checker (CID 2475).

Signed-off-by: Roland Dreier <rolandd@cisco.com>
Acked-by: Steve Wise <swise@opengridcomputing.com>
Roland Dreier 16 年之前
父节点
当前提交
af2b0a1ec3
共有 1 个文件被更改,包括 0 次插入1 次删除
  1. 0 1
      drivers/infiniband/hw/cxgb3/iwch_qp.c

+ 0 - 1
drivers/infiniband/hw/cxgb3/iwch_qp.c

@@ -745,7 +745,6 @@ int iwch_post_zb_read(struct iwch_qp *qhp)
 	wqe->read.rdmaop = T3_READ_REQ;
 	wqe->read.rdmaop = T3_READ_REQ;
 	wqe->read.reserved[0] = 0;
 	wqe->read.reserved[0] = 0;
 	wqe->read.reserved[1] = 0;
 	wqe->read.reserved[1] = 0;
-	wqe->read.reserved[2] = 0;
 	wqe->read.rem_stag = cpu_to_be32(1);
 	wqe->read.rem_stag = cpu_to_be32(1);
 	wqe->read.rem_to = cpu_to_be64(1);
 	wqe->read.rem_to = cpu_to_be64(1);
 	wqe->read.local_stag = cpu_to_be32(1);
 	wqe->read.local_stag = cpu_to_be32(1);