Browse Source

staging: rtl8192e: Fix potential null dereference

check memory is allocated in '*challenge' before using it.

Signed-off-by: Hema Prathaban <hemaklnce@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hema Prathaban 12 years ago
parent
commit
ae053253a7
1 changed files with 3 additions and 1 deletions
  1. 3 1
      drivers/staging/rtl8192e/rtllib_softmac.c

+ 3 - 1
drivers/staging/rtl8192e/rtllib_softmac.c

@@ -1802,7 +1802,9 @@ static inline u16 auth_parse(struct sk_buff *skb, u8** challenge, int *chlen)
 		if (*(t++) == MFIE_TYPE_CHALLENGE) {
 			*chlen = *(t++);
 			*challenge = kmalloc(*chlen, GFP_ATOMIC);
-			memcpy(*challenge, t, *chlen);	/*TODO - check here*/
+			if (!*challenge)
+				return -ENOMEM;
+			memcpy(*challenge, t, *chlen);
 		}
 	}
 	return cpu_to_le16(a->status);