Pārlūkot izejas kodu

net: ppp_generic - use DEFINE_IDR for static initialization

We could use DEFINE_IDR for statically allocated idr
that allow us to save a few lines of code.

And spell fix.

Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Cyrill Gorcunov 16 gadi atpakaļ
vecāks
revīzija
ab5024ab23
1 mainītis faili ar 2 papildinājumiem un 4 dzēšanām
  1. 2 4
      drivers/net/ppp_generic.c

+ 2 - 4
drivers/net/ppp_generic.c

@@ -179,7 +179,7 @@ struct channel {
  */
  */
 static DEFINE_MUTEX(all_ppp_mutex);
 static DEFINE_MUTEX(all_ppp_mutex);
 static atomic_t ppp_unit_count = ATOMIC_INIT(0);
 static atomic_t ppp_unit_count = ATOMIC_INIT(0);
-static struct idr ppp_units_idr;
+static DEFINE_IDR(ppp_units_idr);
 
 
 /*
 /*
  * all_channels_lock protects all_channels and last_channel_index,
  * all_channels_lock protects all_channels and last_channel_index,
@@ -852,8 +852,6 @@ static int __init ppp_init(void)
 			      "ppp");
 			      "ppp");
 	}
 	}
 
 
-	idr_init(&ppp_units_idr);
-
 out:
 out:
 	if (err)
 	if (err)
 		printk(KERN_ERR "failed to register PPP device (%d)\n", err);
 		printk(KERN_ERR "failed to register PPP device (%d)\n", err);
@@ -2435,7 +2433,7 @@ ppp_create_interface(int unit, int *retp)
 		if (unit_find(&ppp_units_idr, unit))
 		if (unit_find(&ppp_units_idr, unit))
 			goto out2; /* unit already exists */
 			goto out2; /* unit already exists */
 		else {
 		else {
-			/* darn, someone is cheatting us? */
+			/* darn, someone is cheating us? */
 			*retp = -EINVAL;
 			*retp = -EINVAL;
 			goto out2;
 			goto out2;
 		}
 		}