Browse Source

chelsio: error path fix

Fix handling of allocation failure.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Stephen Hemminger 18 years ago
parent
commit
ab3b1c7e82
1 changed files with 3 additions and 2 deletions
  1. 3 2
      drivers/net/chelsio/my3126.c

+ 3 - 2
drivers/net/chelsio/my3126.c

@@ -170,9 +170,10 @@ static struct cphy *my3126_phy_create(adapter_t *adapter,
 {
 {
 	struct cphy *cphy = kzalloc(sizeof (*cphy), GFP_KERNEL);
 	struct cphy *cphy = kzalloc(sizeof (*cphy), GFP_KERNEL);
 
 
-	if (cphy)
-		cphy_init(cphy, adapter, phy_addr, &my3126_ops, mdio_ops);
+	if (!cphy)
+		return NULL;
 
 
+	cphy_init(cphy, adapter, phy_addr, &my3126_ops, mdio_ops);
 	INIT_DELAYED_WORK(&cphy->phy_update, my3216_poll);
 	INIT_DELAYED_WORK(&cphy->phy_update, my3216_poll);
 	cphy->bmsr = 0;
 	cphy->bmsr = 0;