Sfoglia il codice sorgente

net: Fix off-by-one in skb_dma_map

The unwind loop iterates down to -1 instead of stopping at 0 and ends up
accessing ->frags[-1].

Signed-off-by: Dimitris Michailidis <dm@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Dimitris Michailidis 16 anni fa
parent
commit
ab396eb03f
1 ha cambiato i file con 1 aggiunte e 1 eliminazioni
  1. 1 1
      net/core/skb_dma_map.c

+ 1 - 1
net/core/skb_dma_map.c

@@ -35,7 +35,7 @@ int skb_dma_map(struct device *dev, struct sk_buff *skb,
 	return 0;
 	return 0;
 
 
 unwind:
 unwind:
-	while (i-- >= 0) {
+	while (--i >= 0) {
 		skb_frag_t *fp = &sp->frags[i];
 		skb_frag_t *fp = &sp->frags[i];
 
 
 		dma_unmap_page(dev, sp->dma_maps[i + 1],
 		dma_unmap_page(dev, sp->dma_maps[i + 1],