Browse Source

dma-buf: Return error instead of using a goto statement when possible

Remove an error label in dma_buf_attach() that just returns an error
code.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
Laurent Pinchart 13 years ago
parent
commit
a9fbc3b731
1 changed files with 1 additions and 3 deletions
  1. 1 3
      drivers/base/dma-buf.c

+ 1 - 3
drivers/base/dma-buf.c

@@ -190,7 +190,7 @@ struct dma_buf_attachment *dma_buf_attach(struct dma_buf *dmabuf,
 
 
 	attach = kzalloc(sizeof(struct dma_buf_attachment), GFP_KERNEL);
 	attach = kzalloc(sizeof(struct dma_buf_attachment), GFP_KERNEL);
 	if (attach == NULL)
 	if (attach == NULL)
-		goto err_alloc;
+		return ERR_PTR(-ENOMEM);
 
 
 	mutex_lock(&dmabuf->lock);
 	mutex_lock(&dmabuf->lock);
 
 
@@ -206,8 +206,6 @@ struct dma_buf_attachment *dma_buf_attach(struct dma_buf *dmabuf,
 	mutex_unlock(&dmabuf->lock);
 	mutex_unlock(&dmabuf->lock);
 	return attach;
 	return attach;
 
 
-err_alloc:
-	return ERR_PTR(-ENOMEM);
 err_attach:
 err_attach:
 	kfree(attach);
 	kfree(attach);
 	mutex_unlock(&dmabuf->lock);
 	mutex_unlock(&dmabuf->lock);