Browse Source

USB gadget: gadgetfs dont try to lock before free

I spotted this during my tests with -rt on arm. The -rt patch contains
some better tools
to diagnose problems with locks and some other things...

Original code tries to take semaphore in BUG_ON and then free the memory
with this semaphore.


Signed-off-by: Milan Svoboda <msvoboda@ra.rockwell.com>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Milan Svoboda 19 years ago
parent
commit
a94da8971e
1 changed files with 0 additions and 1 deletions
  1. 0 1
      drivers/usb/gadget/inode.c

+ 0 - 1
drivers/usb/gadget/inode.c

@@ -223,7 +223,6 @@ static void put_ep (struct ep_data *data)
 	/* needs no more cleanup */
 	/* needs no more cleanup */
 	BUG_ON (!list_empty (&data->epfiles));
 	BUG_ON (!list_empty (&data->epfiles));
 	BUG_ON (waitqueue_active (&data->wait));
 	BUG_ON (waitqueue_active (&data->wait));
-	BUG_ON (down_trylock (&data->lock) != 0);
 	kfree (data);
 	kfree (data);
 }
 }