Browse Source

powerpc/pseries/dlpar: Eliminate use after free

dlpar_free_cc_nodes frees its argument, so dlpar_online_cpu should not be
called on the same value.  Skip over the call to dlpar_online_cpu by
jumping directly to out.

A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression E,E2;
@@

dlpar_free_cc_nodes(E)
...
(
  E = E2
|
* E
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Julia Lawall 15 years ago
parent
commit
a7df5c5e52
1 changed files with 1 additions and 0 deletions
  1. 1 0
      arch/powerpc/platforms/pseries/dlpar.c

+ 1 - 0
arch/powerpc/platforms/pseries/dlpar.c

@@ -433,6 +433,7 @@ static ssize_t dlpar_cpu_probe(const char *buf, size_t count)
 	if (rc) {
 	if (rc) {
 		dlpar_release_drc(drc_index);
 		dlpar_release_drc(drc_index);
 		dlpar_free_cc_nodes(dn);
 		dlpar_free_cc_nodes(dn);
+		goto out;
 	}
 	}
 
 
 	rc = dlpar_online_cpu(dn);
 	rc = dlpar_online_cpu(dn);