浏览代码

IB/mlx4: Unregister IB device prior to CLOSE PORT command

According to the ConnectX programmer's reference manual, all
operations should be stopped, all QPs should be torn down and all WQEs
flushed before the CLOSE_PORT command is invoked.  In some cases
reversing the order of operations (as implemented now) could cause
a loss of completions.

Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Yevgeny Petrilin 16 年之前
父节点
当前提交
a6a47771b1
共有 1 个文件被更改,包括 3 次插入2 次删除
  1. 3 2
      drivers/infiniband/hw/mlx4/main.c

+ 3 - 2
drivers/infiniband/hw/mlx4/main.c

@@ -699,11 +699,12 @@ static void mlx4_ib_remove(struct mlx4_dev *dev, void *ibdev_ptr)
 	struct mlx4_ib_dev *ibdev = ibdev_ptr;
 	struct mlx4_ib_dev *ibdev = ibdev_ptr;
 	int p;
 	int p;
 
 
+	mlx4_ib_mad_cleanup(ibdev);
+	ib_unregister_device(&ibdev->ib_dev);
+
 	for (p = 1; p <= ibdev->num_ports; ++p)
 	for (p = 1; p <= ibdev->num_ports; ++p)
 		mlx4_CLOSE_PORT(dev, p);
 		mlx4_CLOSE_PORT(dev, p);
 
 
-	mlx4_ib_mad_cleanup(ibdev);
-	ib_unregister_device(&ibdev->ib_dev);
 	iounmap(ibdev->uar_map);
 	iounmap(ibdev->uar_map);
 	mlx4_uar_free(dev, &ibdev->priv_uar);
 	mlx4_uar_free(dev, &ibdev->priv_uar);
 	mlx4_pd_free(dev, ibdev->priv_pdn);
 	mlx4_pd_free(dev, ibdev->priv_pdn);