Browse Source

[media] gspca - ov519: Simplify the LED control functions

Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Jean-François Moine 14 years ago
parent
commit
a23acec4bc
1 changed files with 4 additions and 4 deletions
  1. 4 4
      drivers/media/video/gspca/ov519.c

+ 4 - 4
drivers/media/video/gspca/ov519.c

@@ -2639,14 +2639,14 @@ static void ov51x_led_control(struct sd *sd, int on)
 	switch (sd->bridge) {
 	switch (sd->bridge) {
 	/* OV511 has no LED control */
 	/* OV511 has no LED control */
 	case BRIDGE_OV511PLUS:
 	case BRIDGE_OV511PLUS:
-		reg_w(sd, R511_SYS_LED_CTL, on ? 1 : 0);
+		reg_w(sd, R511_SYS_LED_CTL, on);
 		break;
 		break;
 	case BRIDGE_OV518:
 	case BRIDGE_OV518:
 	case BRIDGE_OV518PLUS:
 	case BRIDGE_OV518PLUS:
-		reg_w_mask(sd, R518_GPIO_OUT, on ? 0x02 : 0x00, 0x02);
+		reg_w_mask(sd, R518_GPIO_OUT, 0x02 * on, 0x02);
 		break;
 		break;
 	case BRIDGE_OV519:
 	case BRIDGE_OV519:
-		reg_w_mask(sd, OV519_GPIO_DATA_OUT0, !on, 1);	/* 0 / 1 */
+		reg_w_mask(sd, OV519_GPIO_DATA_OUT0, on, 1);
 		break;
 		break;
 	}
 	}
 }
 }
@@ -2938,7 +2938,7 @@ static int sd_config(struct gspca_dev *gspca_dev,
 	struct cam *cam = &gspca_dev->cam;
 	struct cam *cam = &gspca_dev->cam;
 
 
 	sd->bridge = id->driver_info & BRIDGE_MASK;
 	sd->bridge = id->driver_info & BRIDGE_MASK;
-	sd->invert_led = id->driver_info & BRIDGE_INVERT_LED;
+	sd->invert_led = (id->driver_info & BRIDGE_INVERT_LED) != 0;
 
 
 	switch (sd->bridge) {
 	switch (sd->bridge) {
 	case BRIDGE_OV511:
 	case BRIDGE_OV511: