Pārlūkot izejas kodu

oom_kill: don't call for int_sqrt(0)

There is no need to call for int_sqrt if argument is 0.

Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Christoph Lameter <cl@linux-foundation.org>
Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Cyrill Gorcunov 16 gadi atpakaļ
vecāks
revīzija
a12888f772
1 mainītis faili ar 5 papildinājumiem un 7 dzēšanām
  1. 5 7
      mm/oom_kill.c

+ 5 - 7
mm/oom_kill.c

@@ -55,7 +55,7 @@ static DEFINE_SPINLOCK(zone_scan_lock);
 
 
 unsigned long badness(struct task_struct *p, unsigned long uptime)
 unsigned long badness(struct task_struct *p, unsigned long uptime)
 {
 {
-	unsigned long points, cpu_time, run_time, s;
+	unsigned long points, cpu_time, run_time;
 	struct mm_struct *mm;
 	struct mm_struct *mm;
 	struct task_struct *child;
 	struct task_struct *child;
 
 
@@ -110,12 +110,10 @@ unsigned long badness(struct task_struct *p, unsigned long uptime)
 	else
 	else
 		run_time = 0;
 		run_time = 0;
 
 
-	s = int_sqrt(cpu_time);
-	if (s)
-		points /= s;
-	s = int_sqrt(int_sqrt(run_time));
-	if (s)
-		points /= s;
+	if (cpu_time)
+		points /= int_sqrt(cpu_time);
+	if (run_time)
+		points /= int_sqrt(int_sqrt(run_time));
 
 
 	/*
 	/*
 	 * Niced processes are most likely less important, so double
 	 * Niced processes are most likely less important, so double