Browse Source

ext2: missing unlock in ext2_quota_write()

The inode->i_mutex should be unlocked.

Found by smatch (http://repo.or.cz/w/smatch.git).  Compile tested.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Dan Carpenter 16 years ago
parent
commit
a069e9cee1
1 changed files with 3 additions and 1 deletions
  1. 3 1
      fs/ext2/super.c

+ 3 - 1
fs/ext2/super.c

@@ -1395,8 +1395,10 @@ static ssize_t ext2_quota_write(struct super_block *sb, int type,
 		blk++;
 		blk++;
 	}
 	}
 out:
 out:
-	if (len == towrite)
+	if (len == towrite) {
+		mutex_unlock(&inode->i_mutex);
 		return err;
 		return err;
+	}
 	if (inode->i_size < off+len-towrite)
 	if (inode->i_size < off+len-towrite)
 		i_size_write(inode, off+len-towrite);
 		i_size_write(inode, off+len-towrite);
 	inode->i_version++;
 	inode->i_version++;