Просмотр исходного кода

ext3/ext4: orphan list check on destroy_inode

Customers claims to ext3-related errors, investigation showed that ext3
orphan list has been corrupted and have the reference to non-ext3 inode.
The following debug helps to understand the reasons of this issue.

[akpm@linux-foundation.org: update for print_hex_dump() changes]
Signed-off-by: Vasily Averin <vvs@sw.ru>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Vasily Averin 18 лет назад
Родитель
Сommit
9f7dd93de0
2 измененных файлов с 16 добавлено и 0 удалено
  1. 8 0
      fs/ext3/super.c
  2. 8 0
      fs/ext4/super.c

+ 8 - 0
fs/ext3/super.c

@@ -459,6 +459,14 @@ static struct inode *ext3_alloc_inode(struct super_block *sb)
 
 
 static void ext3_destroy_inode(struct inode *inode)
 static void ext3_destroy_inode(struct inode *inode)
 {
 {
+	if (!list_empty(&(EXT3_I(inode)->i_orphan))) {
+		printk("EXT3 Inode %p: orphan list check failed!\n",
+			EXT3_I(inode));
+		print_hex_dump(KERN_INFO, "", DUMP_PREFIX_ADDRESS, 16, 4,
+				EXT3_I(inode), sizeof(struct ext3_inode_info),
+				false);
+		dump_stack();
+	}
 	kmem_cache_free(ext3_inode_cachep, EXT3_I(inode));
 	kmem_cache_free(ext3_inode_cachep, EXT3_I(inode));
 }
 }
 
 

+ 8 - 0
fs/ext4/super.c

@@ -510,6 +510,14 @@ static struct inode *ext4_alloc_inode(struct super_block *sb)
 
 
 static void ext4_destroy_inode(struct inode *inode)
 static void ext4_destroy_inode(struct inode *inode)
 {
 {
+	if (!list_empty(&(EXT4_I(inode)->i_orphan))) {
+		printk("EXT4 Inode %p: orphan list check failed!\n",
+			EXT4_I(inode));
+		print_hex_dump(KERN_INFO, "", DUMP_PREFIX_ADDRESS, 16, 4,
+				EXT4_I(inode), sizeof(struct ext4_inode_info),
+				true);
+		dump_stack();
+	}
 	kmem_cache_free(ext4_inode_cachep, EXT4_I(inode));
 	kmem_cache_free(ext4_inode_cachep, EXT4_I(inode));
 }
 }