Browse Source

MIPS: Netlogic: Fix sign extension in PIC write

This does not cause a problem yet, but we do not want to write 1
to reserved bits.

Signed-off-by: Jayachandran C <jchandra@broadcom.com>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/5424/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Jayachandran C 12 years ago
parent
commit
9f1f1e7b8b
1 changed files with 1 additions and 1 deletions
  1. 1 1
      arch/mips/include/asm/netlogic/xlp-hal/pic.h

+ 1 - 1
arch/mips/include/asm/netlogic/xlp-hal/pic.h

@@ -315,7 +315,7 @@ nlm_pic_send_ipi(uint64_t base, int hwt, int irq, int nmi)
 {
 	uint64_t ipi;
 
-	ipi = (nmi << 31) | (irq << 20);
+	ipi = ((uint64_t)nmi << 31) | (irq << 20);
 	ipi |= ((hwt >> 4) << 16) | (1 << (hwt & 0xf)); /* cpuset and mask */
 	nlm_write_pic_reg(base, PIC_IPI_CTL, ipi);
 }