浏览代码

drivers/net/ibmveth.c: memset fix

> >> 	Looks like memset() is zeroing wrong nr of bytes.
> >
> > Good catch, however, I think we can just remove this memset altogether
> > since the memory gets allocated via kzalloc.
>
> Correct, that memset() is superfluous.

Ok. Then this should do it.

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>

 drivers/net/ibmveth.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Mariusz Kozlowski 18 年之前
父节点
当前提交
9dc83afdbe
共有 1 个文件被更改,包括 1 次插入2 次删除
  1. 1 2
      drivers/net/ibmveth.c

+ 1 - 2
drivers/net/ibmveth.c

@@ -963,7 +963,7 @@ static int __devinit ibmveth_probe(struct vio_dev *dev, const struct vio_device_
 {
 {
 	int rc, i;
 	int rc, i;
 	struct net_device *netdev;
 	struct net_device *netdev;
-	struct ibmveth_adapter *adapter = NULL;
+	struct ibmveth_adapter *adapter;
 
 
 	unsigned char *mac_addr_p;
 	unsigned char *mac_addr_p;
 	unsigned int *mcastFilterSize_p;
 	unsigned int *mcastFilterSize_p;
@@ -997,7 +997,6 @@ static int __devinit ibmveth_probe(struct vio_dev *dev, const struct vio_device_
 	SET_MODULE_OWNER(netdev);
 	SET_MODULE_OWNER(netdev);
 
 
 	adapter = netdev->priv;
 	adapter = netdev->priv;
-	memset(adapter, 0, sizeof(adapter));
 	dev->dev.driver_data = netdev;
 	dev->dev.driver_data = netdev;
 
 
 	adapter->vdev = dev;
 	adapter->vdev = dev;