Browse Source

[NETFILTER]: xt_TCPMSS: remove network triggerable WARN_ON

ipv6_skip_exthdr() returns -1 for invalid packets. don't WARN_ON
that.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Patrick McHardy 17 năm trước cách đây
mục cha
commit
9dc0564e86
1 tập tin đã thay đổi với 1 bổ sung3 xóa
  1. 1 3
      net/netfilter/xt_TCPMSS.c

+ 1 - 3
net/netfilter/xt_TCPMSS.c

@@ -174,10 +174,8 @@ xt_tcpmss_target6(struct sk_buff *skb,
 
 
 	nexthdr = ipv6h->nexthdr;
 	nexthdr = ipv6h->nexthdr;
 	tcphoff = ipv6_skip_exthdr(skb, sizeof(*ipv6h), &nexthdr);
 	tcphoff = ipv6_skip_exthdr(skb, sizeof(*ipv6h), &nexthdr);
-	if (tcphoff < 0) {
-		WARN_ON(1);
+	if (tcphoff < 0)
 		return NF_DROP;
 		return NF_DROP;
-	}
 	ret = tcpmss_mangle_packet(skb, targinfo, tcphoff,
 	ret = tcpmss_mangle_packet(skb, targinfo, tcphoff,
 				   sizeof(*ipv6h) + sizeof(struct tcphdr));
 				   sizeof(*ipv6h) + sizeof(struct tcphdr));
 	if (ret < 0)
 	if (ret < 0)