Browse Source

libata: add comment documenting PIO latency issues on UP

Based on:
http://lkml.indiana.edu/hypermail/linux/kernel/0908.2/01420.html

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Bartlomiej Zolnierkiewicz 15 năm trước cách đây
mục cha
commit
9cd13bdbae
1 tập tin đã thay đổi với 7 bổ sung0 xóa
  1. 7 0
      drivers/ata/libata-core.c

+ 7 - 0
drivers/ata/libata-core.c

@@ -6616,6 +6616,13 @@ static int __init ata_init(void)
 {
 {
 	ata_parse_force_param();
 	ata_parse_force_param();
 
 
+	/*
+	 * FIXME: In UP case, there is only one workqueue thread and if you
+	 * have more than one PIO device, latency is bloody awful, with
+	 * occasional multi-second "hiccups" as one PIO device waits for
+	 * another.  It's an ugly wart that users DO occasionally complain
+	 * about; luckily most users have at most one PIO polled device.
+	 */
 	ata_wq = create_workqueue("ata");
 	ata_wq = create_workqueue("ata");
 	if (!ata_wq)
 	if (!ata_wq)
 		goto free_force_tbl;
 		goto free_force_tbl;