Преглед на файлове

ext4: Release page references acquired in ext4_da_block_invalidatepages

We forget to release page references we acquire in
ext4_da_block_invalidatepages.  Luckily, this function gets called only if we
are not able to allocate blocks for delay-allocated data so that function
should better never be called.

Also cleanup handling of index variable.

Reported-by: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Jan Kara преди 15 години
родител
ревизия
9b1d0998d2
променени са 1 файла, в които са добавени 3 реда и са изтрити 4 реда
  1. 3 4
      fs/ext4/inode.c

+ 3 - 4
fs/ext4/inode.c

@@ -2157,17 +2157,16 @@ static void ext4_da_block_invalidatepages(struct mpage_da_data *mpd,
 			break;
 			break;
 		for (i = 0; i < nr_pages; i++) {
 		for (i = 0; i < nr_pages; i++) {
 			struct page *page = pvec.pages[i];
 			struct page *page = pvec.pages[i];
-			index = page->index;
-			if (index > end)
+			if (page->index > end)
 				break;
 				break;
-			index++;
-
 			BUG_ON(!PageLocked(page));
 			BUG_ON(!PageLocked(page));
 			BUG_ON(PageWriteback(page));
 			BUG_ON(PageWriteback(page));
 			block_invalidatepage(page, 0);
 			block_invalidatepage(page, 0);
 			ClearPageUptodate(page);
 			ClearPageUptodate(page);
 			unlock_page(page);
 			unlock_page(page);
 		}
 		}
+		index = pvec.pages[nr_pages - 1]->index + 1;
+		pagevec_release(&pvec);
 	}
 	}
 	return;
 	return;
 }
 }